eric
/
pascal_bcrypt
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Change else case to bcUnknown on Line 733 of BCrypt.pas #2

New Issue
Closed
opened 2016-04-26 10:54:33 -07:00 by sikofitt · 0 comments
sikofitt commented 2016-04-26 10:54:33 -07:00 (Migrated from github.com)
Copy Link

The else case on #L733 of BCrypt.pas returns bcPHP on the chance 2a or 2y doesn't match. This is wrong. If someone used 2b, 2c, etc. It would return bcPHP and it would be wrong. It should return bcUnknown.

The else case on [#L733](https://github.com/renegadebbs/pascal_bcrypt/blob/master/BCrypt.pas#L733) of BCrypt.pas returns bcPHP on the chance 2a or 2y doesn't match. **_This is wrong._** If someone used 2b, 2c, etc. It would return bcPHP and it would be wrong. It should return [bcUnknown](https://github.com/renegadebbs/pascal_bcrypt/blob/master/BCrypt.pas#L203).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
3-use-windows-cryptgenrandom-function-instead-of-randomrange
v0.1.0
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eric/pascal_bcrypt#2
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?